Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add azurerm_resource_group resource #1078

Merged
merged 2 commits into from
Oct 4, 2021
Merged

Add azurerm_resource_group resource #1078

merged 2 commits into from
Oct 4, 2021

Conversation

sundowndev
Copy link
Contributor

@sundowndev sundowndev commented Sep 27, 2021 •
edited
Loading

Q A
πŸ› Bug fix? no
πŸš€ New feature? yes
⚠ Deprecations? no
❌ BC Break no
πŸ”— Related issues #1029
❓ Documentation snyk/driftctl-docs#128

Description

This PR implements the azurerm_resource_group resource type.

@sundowndev sundowndev added the kind/enhancement New feature or improvement label Sep 27, 2021
@sundowndev sundowndev force-pushed the feat/add_azurerm_resource_group branch 2 times, most recently from 0794721 to 9765abb Compare September 30, 2021 16:29
@codecov
Copy link

codecov bot commented Sep 30, 2021 •
edited
Loading

Codecov Report

Merging #1078 (0cf7f8b) into main (dd4c896) will decrease coverage by 0.04%.
The diff coverage is 74.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1078      +/-   ##
==========================================
- Coverage   82.00%   81.96%   -0.05%     
==========================================
  Files         287      290       +3     
  Lines        8882     8936      +54     
==========================================
+ Hits         7284     7324      +40     
- Misses       1379     1392      +13     
- Partials      219      220       +1
Impacted Files Coverage Ξ”
pkg/remote/azurerm/init.go 0.00% <0.00%> (ΓΈ)
pkg/resource/resource_types.go 100.00% <ΓΈ> (ΓΈ)
pkg/resource/azurerm/azurerm_resource_group.go 14.28% <14.28%> (ΓΈ)
pkg/remote/azurerm/repository/resources.go 71.42% <71.42%> (ΓΈ)
...emote/azurerm/azurerm_resource_group_enumerator.go 100.00% <100.00%> (ΓΈ)
pkg/resource/azurerm/metadata.go 100.00% <100.00%> (ΓΈ)

@eliecharra eliecharra self-assigned this Oct 1, 2021
eliecharra
eliecharra suggested changes Oct 1, 2021
View reviewed changes
pkg/remote/azurerm/init.go Outdated Show resolved Hide resolved
pkg/resource/azurerm/azurerm_resource_group.go Outdated Show resolved Hide resolved
pkg/resource/azurerm/azurerm_resource_group_test.go Show resolved Hide resolved
pkg/remote/azurerm/repository/armresources.go Outdated Show resolved Hide resolved
pkg/remote/azurerm/repository/armresources.go Outdated Show resolved Hide resolved
pkg/remote/azurerm/repository/armresources.go Outdated Show resolved Hide resolved
@sundowndev sundowndev force-pushed the feat/add_azurerm_resource_group branch 4 times, most recently from 1e0eb3e to fe4a450 Compare October 4, 2021 10:40
@sundowndev sundowndev marked this pull request as ready for review October 4, 2021 10:41
@sundowndev sundowndev requested a review from a team as a code owner October 4, 2021 10:41
eliecharra
eliecharra previously approved these changes Oct 4, 2021
View reviewed changes
Copy link
Contributor

@eliecharra eliecharra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘πŸ» Rebase needed

@sundowndev sundowndev force-pushed the feat/add_azurerm_resource_group branch from 5ff1a2c to 0cf7f8b Compare October 4, 2021 12:28
@eliecharra eliecharra merged commit 576ddb7 into main Oct 4, 2021
@eliecharra eliecharra deleted the feat/add_azurerm_resource_group branch October 4, 2021 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliecharra eliecharra eliecharra approved these changes

Assignees

@eliecharra eliecharra

Labels
kind/enhancement New feature or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sundowndev @eliecharra