Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add azurerm_route_table #1089

Merged
merged 1 commit into from
Oct 4, 2021
Merged

Add azurerm_route_table #1089

merged 1 commit into from
Oct 4, 2021

Conversation

eliecharra
Copy link
Contributor

Q A
πŸ› Bug fix? no
πŸš€ New feature? yes
⚠ Deprecations? no
❌ BC Break no
πŸ”— Related issues #1044
❓ Documentation snyk/driftctl-docs#132

@eliecharra eliecharra requested a review from a team as a code owner October 4, 2021 09:33
@eliecharra eliecharra added the kind/enhancement New feature or improvement label Oct 4, 2021
@codecov
Copy link

codecov bot commented Oct 4, 2021 •
edited
Loading

Codecov Report

Merging #1089 (ce3760b) into main (c8f74fd) will decrease coverage by 0.00%.
The diff coverage is 81.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1089      +/-   ##
==========================================
- Coverage   82.01%   82.00%   -0.01%     
==========================================
  Files         285      287       +2     
  Lines        8834     8882      +48     
==========================================
+ Hits         7245     7284      +39     
- Misses       1371     1379       +8     
- Partials      218      219       +1
Impacted Files Coverage Ξ”
pkg/remote/azurerm/init.go 0.00% <0.00%> (ΓΈ)
pkg/resource/resource_types.go 100.00% <ΓΈ> (ΓΈ)
pkg/resource/azurerm/azurerm_route_table.go 16.66% <16.66%> (ΓΈ)
pkg/remote/azurerm/repository/network.go 75.67% <82.35%> (+5.67%) ⬆️
...g/remote/azurerm/azurerm_route_table_enumerator.go 100.00% <100.00%> (ΓΈ)
pkg/resource/azurerm/metadata.go 100.00% <100.00%> (ΓΈ)

sundowndev
sundowndev previously approved these changes Oct 4, 2021
View reviewed changes
@eliecharra eliecharra merged commit dd4c896 into main Oct 4, 2021
@eliecharra eliecharra deleted the add_azurerm_route_table branch October 4, 2021 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundowndev sundowndev sundowndev approved these changes

Assignees
No one assigned
Labels
kind/enhancement New feature or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eliecharra @sundowndev