Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #1614

Merged
merged 1 commit into from
Jan 25, 2023
Merged

Update README.md #1614

merged 1 commit into from
Jan 25, 2023

Conversation

GeraldCrescione
Copy link
Contributor

removed all links to the website and the invitation to book slots for 1:1 tech discussions and overviews since this is not valid anymore

Q A
🐛 Bug fix? yes/no
🚀 New feature? yes/no
⚠ Deprecations? yes/no
❌ BC Break yes/no
🔗 Related issues #...
❓ Documentation yes

Description

Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context.

removed all links to the website and the invitation to book slots for 1:1 tech discussions and overviews since this is not valid anymore
@GeraldCrescione GeraldCrescione requested a review from a team as a code owner January 25, 2023 07:46
@GeraldCrescione GeraldCrescione requested review from craigfurman and removed request for a team January 25, 2023 07:46
@codecov-commenter
Copy link

Codecov Report

Merging #1614 (9d13e8d) into main (c316510) will decrease coverage by 6.23%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1614      +/-   ##
==========================================
- Coverage   84.29%   78.06%   -6.23%     
==========================================
  Files         229      222       -7     
  Lines        7169     7008     -161     
==========================================
- Hits         6043     5471     -572     
- Misses        967     1340     +373     
- Partials      159      197      +38     
Impacted Files Coverage Δ
pkg/resource/azurerm/azurerm_image.go 12.50% <0.00%> (-87.50%) ⬇️
pkg/resource/azurerm/azurerm_resource_group.go 12.50% <0.00%> (-87.50%) ⬇️
pkg/resource/azurerm/azurerm_container_registry.go 12.50% <0.00%> (-87.50%) ⬇️
pkg/resource/aws/aws_route_table_association.go 13.33% <0.00%> (-86.67%) ⬇️
pkg/resource/google/google_compute_address.go 14.28% <0.00%> (-85.72%) ⬇️
...g/resource/google/google_compute_global_address.go 14.28% <0.00%> (-85.72%) ⬇️
...ce/google/google_compute_instance_group_manager.go 14.28% <0.00%> (-85.72%) ⬇️
pkg/resource/aws/aws_lb.go 16.66% <0.00%> (-83.34%) ⬇️
pkg/resource/google/google_compute_disk.go 16.66% <0.00%> (-83.34%) ⬇️
pkg/resource/google/google_compute_image.go 16.66% <0.00%> (-83.34%) ⬇️
... and 58 more

@CLAassistant
Copy link

CLAassistant commented Jan 25, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@karniwl karniwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @GeraldCrescione, seems you're missing CLA signature so that's needed for merging

@karniwl karniwl merged commit 37e5584 into snyk:main Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants