chore: don't disable acc test KMS keys #1668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When applying acceptance test terraform for AWS KMS key resources, we often see errors of the form: `Failed to set KMS key ... status to false: "NotFoundException: Key '...' does not exist"`. Our current theory is that setting is_enabled=false (as we currently do) is causing terraform to have to perform 2 API operations: create the key, then disable it. Due to the "eventualy consistency" of this API we see this flaking quite often. We don't actually need to disable the keys, so let's not, in an attempt to improve the reliability of this test.
agatakrajewska
approved these changes
Jun 5, 2023
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When applying acceptance test terraform for AWS KMS key resources, we often see errors of the form:
Failed to set KMS key ... status to false: "NotFoundException: Key '...' does not exist". Our current theory is that setting is_enabled=false (as we currently do) is causing terraform to have to perform 2 API operations: create the key, then disable it. Due to the "eventualy consistency" of this API we see this flaking quite often.We don't actually need to disable the keys, so let's not, in an attempt to improve the reliability of this test.