Feat/get ready for yarn2 #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
gitphill
reviewed
Apr 28, 2020
lib/parsers/yarn-lock-parse-base.ts
Outdated
| if (lockfile.type !== this.type) { | ||
| throw new InvalidUserInputError( | ||
| 'Unsupported lockfile provided. ' + | ||
| 'Please provide `package-lock.json`.', |
There was a problem hiding this comment.
yarn.lock? not package-lock.json
There was a problem hiding this comment.
yarn uses yarn.lock file, not the npm way of package-lock.json
There was a problem hiding this comment.
There was a problem hiding this comment.
yep think it was wrong then too 😄
There was a problem hiding this comment.
Actually @gitphill is correct. I now understand the flow better and indeed it should say yarn.lock
There was a problem hiding this comment.
@gitphill addressed your comment 😃
regevbr
approved these changes
Apr 28, 2020
gitphill
reviewed
Apr 28, 2020
gitphill
reviewed
Apr 28, 2020
regevbr
suggested changes
Apr 28, 2020
dkontorovskyy
force-pushed
the
feat/get-ready-for-yarn2
branch
from
8ecfe48
to
6013a18
Compare
|
@gitphill done ✅ Please, take a look again 😃 |
regevbr
approved these changes
Apr 28, 2020
dkontorovskyy
force-pushed
the
feat/get-ready-for-yarn2
branch
4 times, most recently
from
36d4d38
to
7c14431
Compare
gitphill
approved these changes
May 26, 2020
dkontorovskyy
force-pushed
the
feat/get-ready-for-yarn2
branch
from
7c14431
to
0581a37
Compare
dkontorovskyy
force-pushed
the
feat/get-ready-for-yarn2
branch
from
0581a37
to
5aa9d19
Compare
|
🎉 This PR is included in version 1.23.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
Refactor PR #57 together with @regevbr to enable easier rollout for a yarn v2 support