fix: panic in forEachResult.add (#285)

snyk · Mar 22, 2024 · ee7c2af · ee7c2af
1 parent d867732
commit ee7c2af
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/changes/unreleased/Fixed-20240322-114459.yaml b/changes/unreleased/Fixed-20240322-114459.yaml
@@ -0,0 +1,3 @@
+kind: Fixed
+body: panic in forEachResult.add
+time: 2024-03-22T11:44:59.264406+02:00
diff --git a/pkg/hcl_interpreter/term.go b/pkg/hcl_interpreter/term.go
@@ -246,11 +246,13 @@ type forEachResult struct {
 
 func (acc *forEachResult) add(key cty.Value, val cty.Value) {
 	if !acc.isTuple && key.Type() == cty.String {
-		if acc.object == nil {
-			acc.object = map[string]cty.Value{}
+		if !key.IsNull() && key.IsKnown() {
+			if acc.object == nil {
+				acc.object = map[string]cty.Value{}
+			}
+			acc.object[key.AsString()] = val
+			acc.tuple = append(acc.tuple, val)
 		}
-		acc.object[key.AsString()] = val
-		acc.tuple = append(acc.tuple, val)
 	} else {
 		acc.isTuple = true
 		acc.tuple = append(acc.tuple, val)