Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove extra error log #117

Merged
merged 1 commit into from
Dec 9, 2021
Merged

fix: remove extra error log #117

merged 1 commit into from
Dec 9, 2021

Conversation

teodora-sandu
Copy link
Contributor

What this does

This PR has two changes:

  1. Extra validation of the rule name, so it accounts for capitalisation
  2. Removes extra logging so that we don't print out double the errorlogs

Notes for the reviewer

This changes what gets printed out but since the error log was just duplicated we don't think this requires a major version release.

More information

  • Before
    Screenshot 2021-12-09 at 10 14 41
    Screenshot 2021-12-09 at 10 14 37
  • After
    Screenshot 2021-12-09 at 10 14 12

@teodora-sandu teodora-sandu requested a review from a team as a code owner December 9, 2021 10:54
@p0tr3c p0tr3c merged commit bc2df8a into develop Dec 9, 2021
@p0tr3c p0tr3c deleted the fix/remove-extra-error-log branch December 9, 2021 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p0tr3c p0tr3c p0tr3c approved these changes

@ofekatr ofekatr Awaiting requested review from ofekatr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teodora-sandu @p0tr3c