fix: remove incorrect /v1 path [IDE-126] #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
cat2608
approved these changes
Apr 29, 2024
10 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #515 the
/v1was appended in IntelliJ for all calls, even though there are some that don't need it. Only old v1 APIs need this path, otherwise we should leave it out. We noticed this problem by having thesnykCodeConsistentIgnoresfeature flag enabled, which enables a flow that calls some other APIs.In order for this to not introduce a new bug, we need snyk/snyk-ls#498 to get merged first.
Checklist