fix: python circular deps / recursion error #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gemaxim
approved these changes
Feb 5, 2024
|
🎉 This PR is included in version 2.0.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Some python packages, have circular dependencies. For example
apache-airflowrequiresapache-airflow-providers-common-iowhich requiresapache-airflow. This behaviour results in a recursion error:RecursionError: maximum recursion depth exceeded while calling a Python object.
This fix makes sure that if a dependency was already analysed, it won't get analysed again, thus avoiding the recursion error
Any background context you want to provide?
This bug was introduced after fixing another issue
What are the relevant tickets?
Slack conversation
Screenshots