Fixes required for newer Python versions and Linux platform detection. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix detection of Linux platform according to sys.platform doc
|
Thanks for the request @shulai. It's now merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello friend.
I changed the imports to relative imports, making your code compatible with Python 2.6 and up (Also Python 2.5 if you add from future import absolute_import).
Also I fixed the platform detection for Linux (see platform in https://docs.python.org/2/library/sys.html)
Besides those minor changes, so far it works flawlessly in Linux using Python 3.4.
Thanks!!!