Adapt storage engine methods to not convert hashes #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since sociomantic-tsunami#37, the storage engine stores keys internally as integers (hash_t), rather than strings. The existing hash_t-accepting storage methods convert their key into a string, which is passed to the string-accepting method and then converted back to a hash. This commit factors out that double conversion. The hash_t-accepting methods are now the primary methods. Fixes sociomantic-tsunami#92.
nemanja-boric-sociomantic
approved these changes
Jun 25, 2018
|
yay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #37, the storage engine stores keys internally as integers (hash_t),
rather than strings. The existing hash_t-accepting storage methods convert
their key into a string, which is passed to the string-accepting method and
then converted back to a hash. This commit factors out that double
conversion. The hash_t-accepting methods are now the primary methods.
Fixes #92.