Update ocean & dhtproto for fix to Listen disconnection detector #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the disconnection detector could fire in epoll, be unregistered, go out of scope, then be handled in epoll. The patch releases in ocean and dhtproto fix this by removing the disconnection detector from the epoll selected set when it's unregistered. * submodules/dhtproto v13.2.0(d37d420)...v13.2.1(c646488) (1 commits) > Remove Listen DisconnectDetector from epoll selected set when unregistering * submodules/ocean v3.6.1(029feb3)...v3.6.6(31d4b7e) (11 commits) > Add test case for unregister behaviour > Allow removing the client from the selected set in EpollDispatcher.unregister > Make selected_set a member of EpollSelectDispatcher > Do not rethrow from exception_handler > Modify how exception_handler is passed to epoll (...) Fixes sociomantic-tsunami#72.
nemanja-boric-sociomantic
approved these changes
Feb 21, 2018
|
Is the master target branch right? You probably want this as a bugfix. |
|
Yep. I'm just including this in the next normal release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the disconnection detector could fire in epoll, be
unregistered, go out of scope, then be handled in epoll. The patch releases
in ocean and dhtproto fix this by removing the disconnection detector from
the epoll selected set when it's unregistered.
submodules/dhtproto v13.2.0(d37d420)...v13.2.1(c646488) (1 commits)
submodules/ocean v3.6.1(029feb3)...v3.6.6(31d4b7e) (11 commits)
Fixes #72.