Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try refactoring storage channels / engine without using abstract classes in swarm #2

Open
gavin-norman-sociomantic opened this issue Nov 23, 2017 · 0 comments
Milestone

Comments

@gavin-norman-sociomantic

The abstract storage channels / engine classes in swarm are now more of a hindrance than a help. The dmqnode storage system could certainly be refactored in a much cleaner way, without these.

@gavin-norman-sociomantic gavin-norman-sociomantic added this to the v1.8 milestone Nov 23, 2017
@david-eckardt-sociomantic david-eckardt-sociomantic modified the milestones: v1.8, v1.9 Dec 13, 2017
@gavin-norman-sociomantic gavin-norman-sociomantic modified the milestones: v1.9, v1.10 Jan 30, 2018
@gavin-norman-sociomantic gavin-norman-sociomantic modified the milestones: v1.10, v1.11 Mar 22, 2018
Burgos pushed a commit to Burgos/dmqnode that referenced this issue Sep 6, 2019
Fixes sociomantic-tsunami#2.

- Use `VoidBufferAsArrayOf!(cstring)` instead of `cast(cstring[]*)`, which
  is dangerous because the array length is set after the cast.
- Set the array length once instead of appending incrementally.
- Use `parseBody` to parse the value to enforce it is the last field in the
  message payload.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants