Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Update default value of pingTimeout #551

Merged
merged 1 commit into from
Feb 27, 2018
Merged

[chore] Update default value of pingTimeout #551

merged 1 commit into from
Feb 27, 2018

Conversation

darrachequesne
Copy link
Member

@darrachequesne darrachequesne commented Dec 28, 2017 •
edited
Loading

pingTimeout now defaults to 5 seconds.

@darrachequesne
[chore] Update default values for pingTimeout
8c223f8 
`pingTimeout` now defaults to 5 seconds instead of 60 seconds.
@darrachequesne darrachequesne merged commit 65b1ad1 into socketio:master Feb 27, 2018
@darrachequesne darrachequesne deleted the chore/update-pingTimeout branch February 27, 2018 21:03
@darrachequesne darrachequesne changed the title [chore] Update default values for pingInterval and pingTimeout [chore] Update default value of pingTimeout Feb 28, 2018
This was referenced Sep 22, 2018
Closed
Closed
@endze1t
Copy link

endze1t commented Dec 6, 2018

Is there any reason why this was set to 5secs by default? With this new default settings, i received ping timeouts on the client WebSocket is already in CLOSING or CLOSED state.. If i set it back to 60secs on backend, the error is gone.

This was referenced Dec 11, 2018
Open
Open
Merged
@snyk-bot snyk-bot mentioned this pull request Dec 18, 2019
Open
This was referenced Jan 23, 2020
Closed
Open
@snyk-bot snyk-bot mentioned this pull request Feb 17, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Mar 8, 2020
Open
This was referenced Mar 17, 2020
Merged
Merged
Merged
das7pad added a commit to overleaf/real-time that referenced this pull request May 5, 2020
@das7pad
[misc] restore the default pingTimeout of 60s from socket.io v0
8b803a2 
Default in v0:
https://github.com/socketio/socket.io/blob/41b9a7e45d62ead3b4b36dc38cc8c03882ecc577/lib/manager.js#L78

PR that changed the default value in v2:
socketio/engine.io#551
@snyk-bot snyk-bot mentioned this pull request May 27, 2021
Open
This was referenced May 29, 2021
Open
Closed
This was referenced Jun 6, 2021
Open
Open
Closed
Open
Closed
Open
Open
This was referenced Dec 8, 2021
Open
Open
Open
@renovate renovate bot mentioned this pull request Jan 21, 2022
Merged
1 task
This was referenced Feb 4, 2022
Closed
Open
@renovate renovate bot mentioned this pull request Mar 7, 2022
Open
1 task
@dev-mend-for-github-com dev-mend-for-github-com bot mentioned this pull request Apr 12, 2022
Closed
1 task
@dev-mend-for-github-com dev-mend-for-github-com bot mentioned this pull request Apr 24, 2022
Open
1 task
@renovate renovate bot mentioned this pull request May 4, 2022
Closed
1 task
This was referenced Jun 27, 2022
Closed
Merged
@mend-for-github-com mend-for-github-com bot mentioned this pull request Jul 5, 2022
Closed
1 task
@renovate renovate bot mentioned this pull request Jul 24, 2022
Open
1 task
@renovate renovate bot mentioned this pull request Aug 28, 2022
Merged
1 task
@renovate renovate bot mentioned this pull request Oct 20, 2022
Merged
1 task
This was referenced Nov 20, 2022
Open
Open
@mend-for-github-com mend-for-github-com bot mentioned this pull request Nov 20, 2022
Closed
1 task
@renovate renovate bot mentioned this pull request Nov 21, 2022
Merged
1 task
@mend-for-github-com mend-for-github-com bot mentioned this pull request Dec 4, 2022
Closed
1 task
@mend-for-github-com mend-for-github-com bot mentioned this pull request Jan 26, 2023
Closed
1 task
This was referenced Feb 18, 2023
Closed
Closed
@appcues-wss appcues-wss bot mentioned this pull request Mar 16, 2023
Closed
1 task
@appcues-wss appcues-wss bot mentioned this pull request Mar 27, 2023
Closed
1 task
@appcues-wss appcues-wss bot mentioned this pull request Apr 24, 2023
Closed
1 task
This was referenced Jun 16, 2023
Closed
Open
@Omrisnyk Omrisnyk mentioned this pull request Jun 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darrachequesne @endze1t