Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fire an error event on middleware failure for non-root namespace #1202

Merged
merged 1 commit into from
May 17, 2018

Commits on Apr 30, 2018

  1. fix: fire an error event on middleware failure for non-root namespace

    In the following example:
    
    ```js
    io.use((socket, next) => {
      next(new Error('Auth failed'));
    });
    
    // client-side
    const socket = io('https://url/custom-namespace');
    
    socket.on('error', (err) => {
      // ...
    });
    ```
    
    The 'error' event wasn't fired on the custom namespace.
    darrachequesne committed Apr 30, 2018
    Configuration menu
    Copy the full SHA
    97ccfd6 View commit details
    Browse the repository at this point in the history