Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disconnect reasons missing from documentation #4387

Closed
terreng opened this issue Jun 2, 2022 · 2 comments
Closed

Disconnect reasons missing from documentation #4387

terreng opened this issue Jun 2, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@terreng
Copy link

terreng commented Jun 2, 2022

There are a few possible server disconnection reasons that aren't in the documentation. I have come across forced close and forced server close, and there are possibly more. It looks like forced close is also possible on the client side, and it isn't in the client documentation either.

It would be great if these missing client and server disconnection reasons could be added to the documentation to make it easier to determine what they mean. Thank you.

@terreng terreng added the enhancement New feature or request label Jun 2, 2022
darrachequesne added a commit that referenced this issue Sep 13, 2022
Note: some disconnection reasons could be merged in the next major
release, i.e. the Deno impl does not have "forced server close" and
"server shutting down"

Related: #4387
darrachequesne added a commit to socketio/socket.io-website that referenced this issue Sep 13, 2022
@darrachequesne
Copy link
Member

For future readers:

The missing disconnection reasons were added in the documentation: https://socket.io/docs/v4/server-api/#event-disconnect

And also directly in the source code: 10fa4a2

Thanks for the heads-up! 👍

@MatanYemini
Copy link

@darrachequesne How I can get this error? I see it randomly, without any good explanation.. I can dig in the code, but it's not self-explained from the docs :)

Let me also know if you need to me update something regarding it.

dzad pushed a commit to dzad/socket.io that referenced this issue May 29, 2023
Note: some disconnection reasons could be merged in the next major
release, i.e. the Deno impl does not have "forced server close" and
"server shutting down"

Related: socketio#4387
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants