Misc #202
Misc #202
Conversation
…he engine requirement or it will not work with future node versions.
…ket.io-node` requires as that is the name according to the package.json. Also updated the styling to fancy pancy HTML highlighting
| , "dependencies": {} | ||
| , "main": "index" | ||
| , "engines": { "node": "0.4.x" } | ||
| , "engines": { "node": ">= 0.4.0" } |
There was a problem hiding this comment.
wouldn't do that, this bit me with many of my earlier modules
There was a problem hiding this comment.
Both situations are indeed less than ideal, but the previous version was to restrictive this allows 0.4 and >. So I guess there isn't perfect solution for this.
There was a problem hiding this comment.
were you wanting to use it with the 0.5.x stuff? maybe >= 0.4.0 < 0.6.0 would be ok
There was a problem hiding this comment.
Yes, I develop and test all code on 0.4 and 0.5 to ensure a flawless upgrade once a new stable node.js is available.
So I guess a >= 0.4.0 < 0.6.0 would be suitable for this.
Want me to update the commit?
On May 8, 2011, at 7:13 PM, visionmedia wrote:
, "dependencies": {}
, "main": "index"
- , "engines": { "node": "0.4.x" }
- , "engines": { "node": ">= 0.4.0" }
were you wanting to use it with the 0.5.x stuff? maybe
>= 0.4.0 < 0.6.0would be okReply to this email directly or view it on GitHub:
https://github.com/LearnBoost/Socket.IO-node/pull/202/files#r27205
There was a problem hiding this comment.
personally I dont think people should be targeting 0.5.x at all, it's just not really a concern right now but we'll see what @guille thinks. IMO we should leave it at 0.4.x
package.json
Added more keywords, repository and updated the engine so that it actually installs on future node versions
Readme
Changed to fancy pansy
redcarpetenabled syntax highlighting. Changedrequire('socket.io')to `socket.io-node as that is the name according to the package.json and fixed small spelling mistake.