Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Features' section in the README #2824

Merged
merged 3 commits into from
Jan 16, 2017

Conversation

darrachequesne
Copy link
Member

The kind of change this PR does introduce

  • an update to the documentation

Related: #2823

@pherrymason
Copy link

pherrymason commented Jan 13, 2017

👍 Maybe in the part where you explain that Socket.IO is not a WebSocket implementation, you could link to a document where it explains what does that mean?

@darrachequesne
Copy link
Member Author

@raulferras thanks for the feedback! What I meant by that is that since Socket.IO does add some metadata to each packet (i.e. the packet type, the namespace, or the ack id when a message acknowledgement is needed), it will not be able to communicate with someone not talking the same "language". I'll try to rephrase that properly.

@pherrymason
Copy link

Thanks to you @darrachequesne, now is much more clear ;)

@darrachequesne darrachequesne merged commit 23c9dd3 into socketio:master Jan 16, 2017
@darrachequesne darrachequesne deleted the docs/features branch January 16, 2017 22:17
@darrachequesne
Copy link
Member Author

@raulferras again, thanks for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants