Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Include the protocol in the origins check #3198

Merged
merged 1 commit into from
Mar 10, 2018
Merged

[fix] Include the protocol in the origins check #3198

merged 1 commit into from
Mar 10, 2018

Commits on Mar 10, 2018

  1. [fix] Include the protocol in the origins check 

    Previously, the protocol was not taken in account, which caused the following behaviour:

```js
io.origins('https://foo.example.com:443'); // ok as a string
io.origins(['https://foo.example.com:443'); // not ok as an array
```

Fixes socketio#3190
    @darrachequesne
    darrachequesne committed Mar 10, 2018
    Configuration menu
    Copy the full SHA
    ccb66bc View commit details
    Browse the repository at this point in the history