add more typing info and upgrade prettier #3725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- upgrade prettier to 2.2.0 to gain support for TypeScript's new type-only-imports feature.
|
Awesome, thanks! |
dzad
pushed a commit
to dzad/socket.io
that referenced
this pull request
May 29, 2023
This upgrades prettier to 2.2.0 to gain support for TypeScript's new type-only-imports feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new type-only-imports feature.
tests are passing on my local machine (I was a bit confused by the two expected errors at first). You may want to regenerate package-lock.json yourself if you have (what I think is) a healthy level of distrust. I didn't add a malicious package to it, but there's nothing to immediately stop me from doing so.
The kind of change this PR does introduce