Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid direct access to IO internals. #301

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Avoid direct access to IO internals. #301

merged 1 commit into from
Jun 2, 2023

Conversation

ioquatix
Copy link
Member

@ioquatix ioquatix commented Jun 1, 2023

Fixes #299.

Types of Changes

  • Bug fix.
  • Maintenance.

Contribution

@MSP-Greg
Copy link
Contributor

MSP-Greg commented Jun 1, 2023

To clarify, ruby/ruby head/master made ABI changes to IO (see ruby/ruby@18e55fc1e1ec), which caused CI build failures with several extension gems. This was mentioned in #299.

The changes were reverted in ruby/ruby@85dcc4866d9f. But, the head builds used in GitHub Actions setup-ruby are only updated daily, and the builds used for the CI in this PR do not contain the 'reversion' commit.

Hence, this PR works with both the updated IO ABI and the previous ABI, which used in Ruby 3.2.

@ioquatix ioquatix disabled auto-merge June 2, 2023 03:19
@ioquatix ioquatix merged commit 3c1f9b8 into main Jun 2, 2023
@ioquatix ioquatix deleted the avoid-fptr branch June 2, 2023 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ruby head - can't compile on Ubuntu or macOS
2 participants