Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix versions #455

Merged
merged 1 commit into from
Nov 20, 2017
Merged

Fix versions #455

merged 1 commit into from
Nov 20, 2017

Conversation

vext01
Copy link
Member

@vext01 vext01 commented Nov 20, 2017

We should probably freeze the versions of components marked with XXX in build.sh.

I've used the latest versions. The krun tag is the current head.

@ltratt
Copy link
Member

ltratt commented Nov 20, 2017

Do we use libkalibera any more I wonder?

@vext01
Copy link
Member Author

vext01 commented Nov 20, 2017

I wondered the same myself, but I don't want to get into that just now.

I have a vague feeling @snim2 copied the bits we need into warmup_stats:

warmup_stats/warmup/bootstrapper.py: Much of the code here comes from libkalibera.

Here's an issue for this anyway: #456

@ltratt
Copy link
Member

ltratt commented Nov 20, 2017

OK. Merge as-is?

@vext01
Copy link
Member Author

vext01 commented Nov 20, 2017

Let me squash. I fudged the initial commit.

@vext01
Copy link
Member Author

vext01 commented Nov 20, 2017

splat.

@ltratt ltratt merged commit f1102c8 into master Nov 20, 2017
@ltratt ltratt deleted the fix-versions branch November 20, 2017 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ltratt ltratt ltratt approved these changes

Assignees

@ltratt ltratt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vext01 @ltratt