Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add linearDelay for retryDelay option #285

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

yutak23
Copy link
Contributor

@yutak23 yutak23 commented Jul 31, 2024

This ought to fix #276.

To allow the delayFactor to be changed, linearDelay is implemented to return the function required by the retryDelay option.

spec/index.spec.ts Outdated Show resolved Hide resolved
spec/index.spec.ts Outdated Show resolved Hide resolved
@yutak23
Copy link
Contributor Author

yutak23 commented Jul 31, 2024

@mindhells, thank you for your review.

@mindhells
Copy link
Member

thank you @yutak23 !
Only one more thing: it is required to sign the commits to merge your PR 🙏

Update spec/index.spec.ts

Co-authored-by: Alberto Gonzalez <[email protected]>

Update spec/index.spec.ts

Co-authored-by: Alberto Gonzalez <[email protected]>
@yutak23 yutak23 force-pushed the feature/add-linearDelay branch 2 times, most recently from 226f651 to 031ad38 Compare August 1, 2024 09:01
@yutak23
Copy link
Contributor Author

yutak23 commented Aug 1, 2024

thank you @yutak23 ! Only one more thing: it is required to sign the commits to merge your PR 🙏

@mindhells
Added signatures.
However, the force push caused other commits to be unsigned.
Should I combine them into one commit and sign it?

@mindhells
Copy link
Member

thank you @yutak23 ! Only one more thing: it is required to sign the commits to merge your PR 🙏

@mindhells Added signatures. However, the force push caused other commits to be unsigned. Should I combine them into one commit and sign it?

That'd be the best, so I don't have to bypass branch protections to merge 🙇

@yutak23
Copy link
Contributor Author

yutak23 commented Aug 1, 2024

@mindhells ,
I apologize for the trouble i have caused you.
I have pushed the commits together in a rebase and signed it.

@mindhells mindhells merged commit ef00967 into softonic:master Aug 2, 2024
3 checks passed
@mindhells
Copy link
Member

thanks a lot @yutak23 , this has been released as v4.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce "axiosRetry.linearDelay"
2 participants