upgrade go-genproto submodules to avoid ambiguous import errors #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is needed for continue with this task: https://softonic-development.atlassian.net/issues/DS-1907 |
mindhells
approved these changes
Aug 27, 2024
joskfg
reviewed
Aug 28, 2024
joskfg
approved these changes
Aug 28, 2024
Actually this PR is just to upgrade Go version and get rid of Dingo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followed this comment: googleapis/go-genproto#1015
To try and fix the errors I got in the previous build: https://github.com/softonic/homing-pigeon/actions/runs/10347140488/job/28636856541
When creating a grpc connection pool, DialOptions like WithBlock and the
grpc.Dialare bad practices and were deprecated. More info: https://github.com/grpc/grpc-go/blob/master/Documentation/anti-patterns.md