You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Tried upgrading from Swipeable to ReanimatedSwipable but had to rollback.
For some reason the progress value on ReanimatedSwipable updates delayed as to what happened on the UI, the swipeable is already open but the progess.value, onSwipeableOpen, etc all fire 1-2 seconds after. This was not an issue with Swipeable
Steps to reproduce
Test side-by-side a Swipeable and ReanimatedSwipable
Snack or a link to a repository
N/A
Gesture Handler version
2.20.0
React Native version
0.75.4
Platforms
iOS
JavaScript runtime
Hermes
Workflow
Expo bare workflow
Architecture
Paper (Old Architecture)
Build type
Debug mode
Device
iOS simulator
Device model
iPhone 16 Pro Max - iOS 18
Acknowledgements
Yes
The text was updated successfully, but these errors were encountered:
## Description
This PR applies multiple bug fixes and improvements to the
`ReanimatedSwipeable`
### Changes:
- Fix reversed swipe direction being supplied to `open` and `willOpen`
callbacks.
- Fix `startDrag` callbacks receiving invalid `direction` when opening
swipeable.
- Fix unpredictable swipe direction being supplied to `close` and
`willClose` callbacks.
- Fix `onSwipeableWillClose` and `onSwipeableClose` callbacks sometimes
being called on open.
- Fix `progress` value skipping last `10%` of it's range and having a
delay relative to the `translation`.
closes#3147
## Test plan
Will create an example showcasing outputs of all the affected callbacks,
work in progress.
Description
Tried upgrading from
Swipeable
toReanimatedSwipable
but had to rollback.For some reason the
progress
value onReanimatedSwipable
updates delayed as to what happened on the UI, the swipeable is already open but the progess.value, onSwipeableOpen, etc all fire 1-2 seconds after. This was not an issue withSwipeable
Steps to reproduce
Test side-by-side a Swipeable and ReanimatedSwipable
Snack or a link to a repository
N/A
Gesture Handler version
2.20.0
React Native version
0.75.4
Platforms
iOS
JavaScript runtime
Hermes
Workflow
Expo bare workflow
Architecture
Paper (Old Architecture)
Build type
Debug mode
Device
iOS simulator
Device model
iPhone 16 Pro Max - iOS 18
Acknowledgements
Yes
The text was updated successfully, but these errors were encountered: