Fix onBegin
and onTouchesDown
events ordering on Android
#2279
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the ordering of
onBegin
andonTouchesDown
events on Android.onBegin
was invoked first, as some gestures required additional setup when they started tracking the first pointer, which is happening after the touch events are dispatched. The workaround for that was to sendonTouchesDown
later but it resulted in inconsistent behavior between platforms.This behavior is now updated to defer sending the first
onTouchesDown
to a point in time where the gesture is initialized, butonBegin
hasn't been called yet - just before sending theUNDETERMINED
->BEGIN
state change event. This way the correct behavior is kept alongside the correct event ordering without the need to modify every handler.Fixes part of #2263.
Test plan
Tested on the example app and on the code from the issue.