Skip to content

Commit

Permalink
Use " instead of < for JSIStoreValueUser.h include (#1768)
Browse files Browse the repository at this point in the history
## Description

`JSIStoreValueUser.h` is a local file, use `"` instead of `<` for importing user headers.

This compiled fine before since CocoaPods allows flattening system headers, but once I try to import some REA headers in another library, it fails to compile:

![Screenshot 2021-02-27 at 21 38 40](https://user-images.githubusercontent.com/15199031/109399602-29be3380-7944-11eb-867e-a81db095ef95.png)
  • Loading branch information
mrousavy authored Mar 1, 2021
1 parent ec10502 commit 50cf5ca
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions Common/cpp/headers/SharedItems/ShareableValue.h
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@
#include "Logger.h"
#include "ValueWrapper.h"
#include "HostFunctionHandler.h"
#include "JSIStoreValueUser.h"
#include <string>
#include <mutex>
#include <unordered_map>
#include <jsi/jsi.h>
#include <JSIStoreValueUser.h>

using namespace facebook;

Expand All @@ -30,7 +30,7 @@ friend void extractMutables(jsi::Runtime &rt,
bool containsHostFunction = false;

ShareableValue(NativeReanimatedModule *module, std::shared_ptr<Scheduler> s): StoreUser(s), module(module) {}

jsi::Value toJSValue(jsi::Runtime &rt);
jsi::Object createHost(jsi::Runtime &rt, std::shared_ptr<jsi::HostObject> host);
void adapt(jsi::Runtime &rt, const jsi::Value &value, ValueType objectType);
Expand Down
10 changes: 5 additions & 5 deletions Common/cpp/headers/SharedItems/ValueWrapper.h
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
#include "WorkletsCache.h"
#include "SharedParent.h"
#include <jsi/jsi.h>
#include <JSIStoreValueUser.h>
#include <string>
#include "JSIStoreValueUser.h"
#include "HostFunctionHandler.h"

namespace reanimated {
Expand All @@ -18,9 +18,9 @@ class ValueWrapper {
ValueType getType() const {
return type;
}

virtual ~ValueWrapper() {}

static inline bool asBoolean(const std::unique_ptr<ValueWrapper>& valueContainer);
static inline double asNumber(const std::unique_ptr<ValueWrapper>& valueContainer);
static inline const std::string& asString(const std::unique_ptr<ValueWrapper>& valueContainer);
Expand All @@ -29,9 +29,9 @@ class ValueWrapper {
static inline const std::shared_ptr<RemoteObject>& asRemoteObject(const std::unique_ptr<ValueWrapper>& valueContainer);
static inline std::vector<std::shared_ptr<ShareableValue>>& asFrozenArray(const std::unique_ptr<ValueWrapper>& valueContainer);
static inline const std::shared_ptr<MutableValue>& asMutableValue(const std::unique_ptr<ValueWrapper>& valueContainer);

static const HostFunctionWrapper* asHostFunctionWrapper(const std::unique_ptr<ValueWrapper>& valueContainer);

protected:
ValueType type;
};
Expand Down

0 comments on commit 50cf5ca

Please sign in to comment.