Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert CATransform3d using [NSValue valueWithCATransform3D] #254

Merged
merged 1 commit into from
Apr 25, 2019
Merged

Convert CATransform3d using [NSValue valueWithCATransform3D] #254

merged 1 commit into from
Apr 25, 2019

Conversation

xkrsz
Copy link
Contributor

@xkrsz xkrsz commented Apr 24, 2019

Converting a type with boxed constraints caused Illegal type 'CATransform3D' (aka 'struct CATransform3D') used in a boxed expression.

Thanks @sochalewski for the tip.

Fixes #236

…tead of boxed constraint

chore: fix syntax
@osdnk
Copy link
Contributor

osdnk commented Apr 25, 2019

Why can't you use the new Xcode version?

@xkrsz
Copy link
Contributor Author

xkrsz commented Apr 25, 2019

Some projects simply do not support it, they have dependencies (custom or 3rd party) which aren’t compatible with newer versions. Is that PR introducing any potential issues? I don’t think adding a backward compatible change is bad if it doesn’t.

Copy link
Contributor

@osdnk osdnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🇮🇹

@osdnk osdnk merged commit 0a6405d into software-mansion:master Apr 25, 2019
@awidiyadew
Copy link

When this PR will be released? I need this changes

@xkrsz xkrsz deleted the boxed-constraint-fix branch May 13, 2019 07:56
@xkrsz
Copy link
Contributor Author

xkrsz commented May 14, 2019

@awidiyadew Just patch it with patch-package in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I'cant get build on iOS Illegal type 'CATransform3D'
4 participants