Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes of dark-theme and values in docs #6058

Merged
merged 10 commits into from
Jun 11, 2024

Conversation

patrycjakalinska
Copy link
Collaborator

@patrycjakalinska patrycjakalinska commented May 28, 2024

Add offset 'margins' so withDecay example would look cleaner

Before:

Screen.Recording.2024-05-29.at.11.00.42.mov

After:

Screen.Recording.2024-05-29.at.11.00.58.mov

Add dark theme to Section List and Bottom Sheet

Before:

image image

After:

image image

Fix --swm-dropdown-versions-item color on light-theme

Before:

image

After:

image

Remove different background on Examples' sidebar

Before:

image

After:

image

@patrycjakalinska patrycjakalinska changed the title Fixes of style and values in docs Fixes of dark-theme and values in docs May 29, 2024
@patrycjakalinska patrycjakalinska force-pushed the @patrycjakalinska/stylistic-fixed-docs branch from 19949fe to 2feb5e4 Compare May 29, 2024 08:24
Copy link
Member

@kacperkapusciak kacperkapusciak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on light mode on landing the dropdown title should be white on light mode

image

not broken on this PR could be fixed: in examples the background color of titles on the left side is incorrect:
image
there's a difference in tone both on light and dark mode

Copy link
Member

@kacperkapusciak kacperkapusciak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found one more visual glitch where material ui inputs are always in dark mode but it can be fixed in another PR

image image

@kacperkapusciak
Copy link
Member

don't merge it yet please, let guys release 3.12.0 from main

@kacperkapusciak
Copy link
Member

Okay, let's resolve the conflicts and I think it's ready to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants