Fix eslint rules and types of tests #6103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjzel
requested changes
Jun 12, 2024
apps/common-app/src/examples/RuntimeTests/ReanimatedRuntimeTestsRunner/RuntimeTestsApi.ts
Show resolved
Hide resolved
apps/common-app/src/examples/RuntimeTests/ReanimatedRuntimeTestsRunner/RuntimeTestsApi.ts
Show resolved
Hide resolved
apps/common-app/src/examples/RuntimeTests/ReanimatedRuntimeTestsRunner/RuntimeTestsApi.ts
Show resolved
Hide resolved
apps/common-app/src/examples/RuntimeTests/ReanimatedRuntimeTestsRunner/TestRunner.ts
Show resolved
Hide resolved
apps/common-app/src/examples/RuntimeTests/ReanimatedRuntimeTestsRunner/TestRunner.ts
Show resolved
Hide resolved
apps/common-app/src/examples/RuntimeTests/ReanimatedRuntimeTestsRunner/types.ts
Show resolved
Hide resolved
apps/common-app/src/examples/RuntimeTests/ReanimatedRuntimeTestsRunner/types.ts
Show resolved
Hide resolved
apps/common-app/src/examples/RuntimeTests/tests/animations/withTiming/arrays.test.tsx
Outdated
Show resolved
Hide resolved
apps/common-app/src/examples/RuntimeTests/tests/animations/withTiming/objects.test.tsx
Outdated
Show resolved
Hide resolved
apps/common-app/src/examples/RuntimeTests/tests/core/useSharedValue.test.tsx
Show resolved
Hide resolved
|
The name of this PR is a bit misleading because it does more than just fixing monorepo compatibility |
Latropos
changed the title
piaskowyk
approved these changes
Jun 13, 2024
apps/common-app/src/examples/RuntimeTests/tests/animations/withTiming/arrays.test.tsx
Outdated
Show resolved
Hide resolved
tjzel
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since we have introduced monorepo code of example application was provided with more restrictive eslint rules, so I have to either fix runtime tests or disable some of the rules. I do both depending on the case.
no-template-curly-in-string, because of test-each syntax uses string slooking like string templateRuntimeTestsApi.ts, to rewrite types of test & describeTest plan
Tested on IOS