Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix web-example #6111

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Fix web-example #6111

merged 1 commit into from
Jun 13, 2024

Conversation

m-bert
Copy link
Contributor

@m-bert m-bert commented Jun 12, 2024

Summary

Following the transition to a monorepo structure, our web-example app stopped working due to an asset loading issue. Turns out that the getAssetByID function from react-native-web was being called from the incorrect module. We believe this might have resulted in one module blocking an asset while another module was trying to load it, causing the application to crash.

This PR modifies the metro.config.js inside the web-example folder. It is now configured to ignore the @react-native module from the root, which allows assets to load correctly.

Test plan

Run web-example.

@m-bert m-bert requested review from piaskowyk and tjzel June 12, 2024 16:29
@piaskowyk piaskowyk added this pull request to the merge queue Jun 13, 2024
Merged via the queue into main with commit 5e830b2 Jun 13, 2024
6 checks passed
@piaskowyk piaskowyk deleted the @mbert/fix-monorepo-web branch June 13, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants