[LA] Replace Layout Transitions example #6151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrycjakalinska
changed the title
piaskowyk
reviewed
Jun 24, 2024
apps/common-app/src/examples/LayoutAnimations/LayoutTransitionExample.tsx
Show resolved
Hide resolved
apps/common-app/src/examples/LayoutAnimations/LayoutTransitionExample.tsx
Show resolved
Hide resolved
apps/common-app/src/examples/LayoutAnimations/LayoutTransitionExample.tsx
Outdated
Show resolved
Hide resolved
apps/common-app/src/examples/LayoutAnimations/LayoutTransitionExample.tsx
Outdated
Show resolved
Hide resolved
apps/common-app/src/examples/LayoutAnimations/LayoutTransitionExample.tsx
Outdated
Show resolved
Hide resolved
apps/common-app/src/examples/LayoutAnimations/LayoutTransitionExample.tsx
Outdated
Show resolved
Hide resolved
piaskowyk
approved these changes
Jun 28, 2024
apps/common-app/src/examples/LayoutAnimations/LayoutTransitionExample.tsx
Outdated
Show resolved
Hide resolved
Merged
patrycjakalinska
force-pushed
the
@patrycjakalinska/replace-layout-transition-example
branch
from
e454c2e
to
d0bf50c
Compare
patrycjakalinska
deleted the
@patrycjakalinska/replace-layout-transition-example
branch
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 1, 2024
## Summary This PR aims to fix some unexpected behaviour during `FadingTransition`. | before | after | | --- | --- | | <video src="https://github.com/software-mansion/react-native-reanimated/assets/36106620/e855c796-a926-48bf-b55d-80014694043d" /> | <video src="https://github.com/software-mansion/react-native-reanimated/assets/36106620/004bd2f6-2bb7-41b2-af1d-6d98a94908c0" /> | Expected behavior: - The component stays in the original position. - Starts the fade-out animation. - Wen component is invisible, changes position to the target position. - Starts the fade-in animation. In the previous approach, when the `delayFunction` was not specified (when no one called `.delay()`), the component jumped to the final position after 50ms instead of waiting until the component became invisible. ## Test plan I tested it on the example from #6151
This was referenced Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We replaced
Default Layout Transitionwith refreshed example.Before:
After:
Screen.Recording.2024-06-21.at.13.22.39.mov