-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Name every worklet function #6163
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomiejbloniarz
approved these changes
Jul 2, 2024
tomekzaw
requested changes
Jul 2, 2024
piaskowyk
reviewed
Jul 3, 2024
tomekzaw
reviewed
Jul 8, 2024
piaskowyk
approved these changes
Jul 8, 2024
tomekzaw
reviewed
Jul 16, 2024
tomekzaw
reviewed
Jul 16, 2024
tomekzaw
reviewed
Jul 16, 2024
packages/react-native-reanimated/plugin/src/workletStringCode.ts
Outdated
Show resolved
Hide resolved
tomekzaw
reviewed
Jul 16, 2024
tomekzaw
approved these changes
Jul 16, 2024
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 22, 2024
## Summary After #6163 was merged, each `worklet` function follows new naming convention. Since `easings` are `worklets`, their `name` property has also been changed. In web layout animations we were applying `easing` based on its name, therefore changing it resulted in only default `linear` easing being available on web. This PR adds new `Symbol` into easing functions so that we can once again get their name and apply correct easing to animations. ## Test plan Tested on _**BasicLayoutAnimation**_ example with `Easing.exp`
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 28, 2024
## Summary Turns out that in #6163 I overlooked the fact that we shouldn't rename React part of worklet functions. This PR changes the naming behavior, only worklet counterparts are renamed for better error verbosity. See differences in snapshots for more details. ## Test plan - [x] Upgraded jest unit tests pass - [x] New runtime tests pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, in case of unnamed worklets, such as
Those functions are named
anonymous
and parsed as such on the Worklet Runtime. However, this is a pitfall for Reanimated. When theanonymous
function crashes and the stack trace is vague - it usually is, especially in production - the first suspicion is the error in Reanimated's core logic, since we don't know which function in particular has failed.In case of a faulty logic in a third-party library this is double as harmful. It doesn't lead the creators of these libraries into the pit of success, since they might not be aware it's their code causing issues. Conversely, Reanimated maintainers receive a very obscure issue and engage in rather unpleasant debugging process - only to discover later the library's fault.
My idea is to:
Test plan
Sentry stack traces are coming from Android. Unfortunately, regardless of these changes iOS Sentry stack traces look like this: