refactor: Split cmake and podspec for worklets #6334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjzel
force-pushed
the
@tjzel/worklets/split-cmake-and-podspec
branch
from
1116f98
to
eb5c0d6
Compare
tomekzaw
requested changes
Jul 26, 2024
packages/react-native-reanimated/Common/cpp/Tools/ReanimatedHiddenHeaders.h
Show resolved
Hide resolved
packages/react-native-reanimated/android/src/main/worklets/CMakeLists.txt
Outdated
Show resolved
Hide resolved
packages/react-native-reanimated/android/src/main/reanimated/CMakeLists.txt
Outdated
Show resolved
Hide resolved
packages/react-native-reanimated/android/src/main/reanimated/CMakeLists.txt
Outdated
Show resolved
Hide resolved
packages/react-native-reanimated/android/src/main/reanimated/CMakeLists.txt
Outdated
Show resolved
Hide resolved
packages/react-native-reanimated/android/src/main/reanimated/CMakeLists.txt
Outdated
Show resolved
Hide resolved
tomekzaw
requested changes
Jul 26, 2024
packages/react-native-reanimated/android/src/main/reanimated/CMakeLists.txt
Outdated
Show resolved
Hide resolved
packages/react-native-reanimated/android/src/main/worklets/CMakeLists.txt
Outdated
Show resolved
Hide resolved
tomekzaw
requested changes
Jul 30, 2024
packages/react-native-reanimated/android/src/main/worklets/CMakeLists.txt
Outdated
Show resolved
Hide resolved
packages/react-native-reanimated/android/src/main/worklets/CMakeLists.txt
Outdated
Show resolved
Hide resolved
packages/react-native-reanimated/android/src/main/worklets/CMakeLists.txt
Outdated
Show resolved
Hide resolved
packages/react-native-reanimated/android/src/main/worklets/CMakeLists.txt
Show resolved
Hide resolved
tomekzaw
approved these changes
Jul 30, 2024
packages/react-native-reanimated/android/src/main/worklets/CMakeLists.txt
Show resolved
Hide resolved
This was referenced Sep 24, 2024
This was referenced Oct 1, 2024
This was referenced Oct 3, 2024
This was referenced Oct 4, 2024
This was referenced Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is another step towards extracting
react-native-worklets. We splitCMakeLists.txtfor targetsreanimatedandworklets, and also split.podspecfor two subspecs.The native code is still a bit tangled (Worklets require headers from Reanimated etc.), it will be tackled in future PRs.
Test plan
Example apps build and run: