Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Light mode colors in the make mutable example in docs #6375

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

MatiPl01
Copy link
Member

@MatiPl01 MatiPl01 commented Aug 5, 2024

Summary

I used useColorScheme hook from react-native instead of the one from the @mui/material library, which returned 'dark' color scheme name irrespective of the actual selected theme.

This PR changes the hook to the correct one which fixes the text color in the light mode.

Example screenshots

Light theme

Before After
Screenshot 2024-08-05 at 18 18 19 Screenshot 2024-08-05 at 18 16 25

Dark theme

Works fine, as before.

Before After
Screenshot 2024-08-05 at 18 17 42 Screenshot 2024-08-05 at 18 17 03

Test plan

  • cd packages/reanimated-docs,
  • yarn start,
  • navigate to the makeMutable page in docs and see the example

@MatiPl01 MatiPl01 self-assigned this Aug 5, 2024
Copy link
Contributor

@bartlomiejbloniarz bartlomiejbloniarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@MatiPl01 MatiPl01 added this pull request to the merge queue Aug 5, 2024
@MatiPl01 MatiPl01 changed the title fix: Light mode colors of the make mutable example in docs fix: Light mode colors in the make mutable example in docs Aug 5, 2024
Merged via the queue into main with commit d8ef9c2 Aug 5, 2024
6 checks passed
@MatiPl01 MatiPl01 deleted the @matipl01/fix-makeMutable-docs-example-colors branch August 5, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants