fix(Android): minSdkVersion fallback to default 21 but RN 0.74 require minSdkVersion 23 #2346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e minSdkVersion 23
adrianryt
force-pushed
the
fix-minSdkVersion-name-change
branch
from
f652f94
to
b9e05fa
Compare
ja1ns
pushed a commit
to WiseOwlTech/react-native-screens
that referenced
this pull request
Oct 9, 2024
…e minSdkVersion 23 (software-mansion#2346) ## Description This PR is a potential fix for [software-mansion#2295](software-mansion#2295). Following suggestions in [PR#2251](software-mansion#2251 (comment)) and Android Gradle Plugin version 7.0.0 changes: `minSdkVersion` was renamed to `minSdk`, `targetSdkVersion` was renamed to `targetSdk`, `compileSdkVersion` was renamed to `compileSdk`, this PR ensures compatibility with react native integrated with newest Android projects. Fixes software-mansion#2295 <!-- Description and motivation for this PR. Include Fixes #<number> if this is fixing some issue. Fixes # . --> ## Changes In `adroid/build.gradle` file to get value for `minSdkVersion` in `defaultConfig` it will look for `minSdkVersion` in rootProject then look for `minSdk` and then fallback to default. Previously it looked for `minSdkVersion` and fallback if not found. Similar logic for `targetSdkVersion` and `compileSdkVersion` <!-- Please describe things you've changed here, make a **high level** overview, if change is simple you can omit this section. For example: - Updated `about.md` docs --> <!-- ## Screenshots / GIFs Here you can add screenshots / GIFs documenting your change. You can add before / after section if you're changing some behavior. ### Before ### After --> ## Test code and steps to reproduce <!-- Please include code that can be used to test this change and short description how this example should work. This snippet should be as minimal as possible and ready to be pasted into editor (don't exclude exports or remove "not important" parts of reproduction example) --> ## Checklist - [ ] Included code example that can be used to test this change - [ ] Updated TS types - [ ] Updated documentation: <!-- For adding new props to native-stack --> - [ ] https://github.com/software-mansion/react-native-screens/blob/main/guides/GUIDE_FOR_LIBRARY_AUTHORS.md - [ ] https://github.com/software-mansion/react-native-screens/blob/main/native-stack/README.md - [ ] https://github.com/software-mansion/react-native-screens/blob/main/src/types.tsx - [ ] https://github.com/software-mansion/react-native-screens/blob/main/src/native-stack/types.tsx - [ ] Ensured that CI passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a potential fix for #2295. Following suggestions in PR#2251 and Android Gradle Plugin version 7.0.0 changes:
minSdkVersionwas renamed tominSdk,targetSdkVersionwas renamed totargetSdk,compileSdkVersionwas renamed tocompileSdk, this PR ensures compatibility with react native integrated with newest Android projects.Fixes #2295
Changes
In
adroid/build.gradlefile to get value forminSdkVersionindefaultConfigit will look forminSdkVersionin rootProject then look forminSdkand then fallback to default. Previously it looked forminSdkVersionand fallback if not found.Similar logic for
targetSdkVersionandcompileSdkVersionTest code and steps to reproduce
Checklist