Fix nested SVGs in iOS #1437 #1603
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1437 #1495.
Nested SVGs with gradients are rendered now in iOS
In the current implementation nested SVGs don't call the
[svg parseReference];which is needed for the brush creation.This happens because of this if-clause RNSVGSvgView.m:208-210.
Moved the call of
[svg parseReference];from- (void)drawRect:(CGRect)rectto- (void)drawToContext:(CGContextRef)context withRect:(CGRect)rect.Since it also loops through the subviews and is called for all SVGs.
Test Plan
Code shown in #1437.
Compatibility
Checklist
README.md__tests__folder