Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove using pattern matching in FilterView #2354

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

bohdanprog
Copy link
Member

Summary

Closes #2347
Fixed a problem with building an Android app, pattern matching threw an error when we tried to build an Android app.
Repository to reproduce that error.

Test Plan

We can easily check that build the app.

What are the steps to reproduce (after prerequisites)?

build the app without that fix.

Compatibility

OS Implemented
Android

@bohdanprog bohdanprog requested a review from jakex7 July 18, 2024 08:36
@bohdanprog bohdanprog self-assigned this Jul 18, 2024
Copy link
Member

@jakex7 jakex7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bohdanprog bohdanprog marked this pull request as ready for review July 18, 2024 08:42
@bohdanprog bohdanprog merged commit b8ff336 into main Jul 18, 2024
3 checks passed
@bohdanprog bohdanprog deleted the fix/android-build-with-new-rnsvg branch July 18, 2024 08:52
@1mike12
Copy link

1mike12 commented Jul 20, 2024

nice job man

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error: pattern matching in instanceof is not supported in -source 8
3 participants