fix: applying multiple filters on iOS #2366
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Applying multiple
FeColorFilter
instances can cause unexpected behavior on iOS, likely due to a bug inCoreImage
where theCIImage
recipe isn't applied step by step as it should be. This fix ensures that the filter result is rendered after each application by converting the image toCGImage
and then back toCIImage
.Test Plan
With this simple test, we can prove that these changes are working