-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: prometheus attributes format to otel attributes #4122
Open
varshith257
wants to merge
7
commits into
softwaremill:master
Choose a base branch
from
varshith257:refactor/OTEL-attributes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
refactor!: prometheus attributes format to otel attributes #4122
varshith257
wants to merge
7
commits into
softwaremill:master
from
varshith257:refactor/OTEL-attributes
+86
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varshith257
force-pushed
the
refactor/OTEL-attributes
branch
from
October 29, 2024 18:53
02c2236
to
585a57a
Compare
@sergiuszkierat I just worked this a few days ago and haven't pushed here :) |
Just need tweaks here to this PR. Once it is done I will tag you here |
@varshith257 Thanks for letting me know. Better late than never 😅 I can freely switch to another task |
varshith257
force-pushed
the
refactor/OTEL-attributes
branch
from
October 30, 2024 12:11
585a57a
to
9fd29dc
Compare
@adamw It's ready for your review |
adamw
reviewed
Oct 31, 2024
server/core/src/main/scala/sttp/tapir/server/metrics/Metric.scala
Outdated
Show resolved
Hide resolved
adamw
reviewed
Oct 31, 2024
server/core/src/main/scala/sttp/tapir/server/metrics/Metric.scala
Outdated
Show resolved
Hide resolved
adamw
reviewed
Oct 31, 2024
...ry-metrics/src/main/scala/sttp/tapir/server/metrics/opentelemetry/OpenTelemetryMetrics.scala
Show resolved
Hide resolved
Will definitely look into it
…On Thu, 31 Oct, 2024, 2:41 pm Sergiusz Kierat, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In
metrics/opentelemetry-metrics/src/main/scala/sttp/tapir/server/metrics/opentelemetry/OpenTelemetryMetrics.scala
<#4122 (comment)>:
> @@ -80,7 +80,7 @@ object OpenTelemetryMetrics {
def requestActive[F[_]](meter: Meter, labels: MetricLabels): Metric[F, LongUpDownCounter] =
Metric[F, LongUpDownCounter](
meter
- .upDownCounterBuilder("request_active")
+ .upDownCounterBuilder("http.server.active_requests")
are all metrics that we should report, included here, or is there anything
missing?
I guess that having those optional metrics (http.server.request.body.size
<https://opentelemetry.io/docs/specs/semconv/http/http-metrics/#metric-httpserverrequestbodysize>
,
http.server.response.body.size
<https://opentelemetry.io/docs/specs/semconv/http/http-metrics/#metric-httpserverresponsebodysize>)
would be useful 😁
—
Reply to this email directly, view it on GitHub
<#4122 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A4BF3HCGZPMQ2TVJIAY4MP3Z6HX4JAVCNFSM6AAAAABQ2Q6GUGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIMBXGQZDMMJXG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
varshith257
force-pushed
the
refactor/OTEL-attributes
branch
from
November 2, 2024 11:36
453389b
to
ca9550f
Compare
varshith257
changed the title
refactor: prometheus attributes format to otel attributes
refactor!: prometheus attributes format to otel attributes
Nov 3, 2024
adamw
reviewed
Nov 4, 2024
server/core/src/main/scala/sttp/tapir/server/metrics/Metric.scala
Outdated
Show resolved
Hide resolved
adamw
reviewed
Nov 4, 2024
server/core/src/main/scala/sttp/tapir/server/metrics/Metric.scala
Outdated
Show resolved
Hide resolved
varshith257
force-pushed
the
refactor/OTEL-attributes
branch
from
November 8, 2024 05:35
38bf6fd
to
b433cda
Compare
@adamw Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/claim #4057
Closes #4057