Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: prometheus attributes format to otel attributes #4122

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

varshith257
Copy link

@varshith257 varshith257 commented Oct 29, 2024

/claim #4057
Closes #4057

@varshith257
Copy link
Author

@sergiuszkierat I just worked this a few days ago and haven't pushed here :)

@varshith257
Copy link
Author

Just need tweaks here to this PR. Once it is done I will tag you here

@sergiuszkierat
Copy link

@sergiuszkierat I just worked this a few days ago and haven't pushed here :)

@varshith257 Thanks for letting me know. Better late than never 😅 I can freely switch to another task

@varshith257 varshith257 marked this pull request as ready for review October 30, 2024 17:21
@varshith257
Copy link
Author

@adamw It's ready for your review

@varshith257
Copy link
Author

varshith257 commented Oct 31, 2024 via email

@varshith257 varshith257 changed the title refactor: prometheus attributes format to otel attributes refactor!: prometheus attributes format to otel attributes Nov 3, 2024
@varshith257
Copy link
Author

@adamw Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust OpenTelemetry metric names, add require attributes
3 participants