Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduced-order syngen models #213

Merged
merged 68 commits into from
Jul 4, 2023
Merged

Conversation

dinkelbachjan
Copy link
Contributor

@dinkelbachjan dinkelbachjan commented Apr 17, 2023

This PR covers the implementation of iterative reduced-order synchronous generator models, namely the PCM and TPM models. Besides, it removes the DCIM implementations, which are covered now by PCM models with zero iterations in the DP domain. It also refactors the VBR model implementations and involves a new DP-DQ interface, which is used by all DP reduced-order synchronous generator models (PCM, TPM, VBR) and shall be reused by other DQ based components in the future. Furthermore, it adds several validation notebooks to compare the different reduced-order models against each other and to compare the results of the 4th order VBR model in the WSCC benchmark system against results from PSAT.

Based on #199
Rebase of #207
Related to #75, #221 and #225

@dinkelbachjan dinkelbachjan force-pushed the iterative_syngens_config_solver branch from 10c1466 to 8fa8386 Compare April 17, 2023 10:03
@sonarcloud
Copy link

sonarcloud bot commented Apr 17, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug E 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 96 Code Smells

0.0% 0.0% Coverage
2.9% 2.9% Duplication

@dinkelbachjan dinkelbachjan force-pushed the iterative_syngens_config_solver branch 6 times, most recently from 77d0452 to dbab5b6 Compare June 13, 2023 09:34
@dinkelbachjan dinkelbachjan self-assigned this Jun 15, 2023
dinkelbachjan and others added 20 commits June 15, 2023 11:21
Signed-off-by: Jan Dinkelbach <[email protected]>
Signed-off-by: Martin Moraga <[email protected]>
Signed-off-by: Martin Moraga <[email protected]>
Signed-off-by: Martin Moraga <[email protected]>
Signed-off-by: Martin Moraga <[email protected]>
Signed-off-by: Martin Moraga <[email protected]>
Signed-off-by: Martin Moraga <[email protected]>
Signed-off-by: Jan Dinkelbach <[email protected]>
Signed-off-by: Jan Dinkelbach <[email protected]>
Signed-off-by: Jan Dinkelbach <[email protected]>
dinkelbachjan and others added 15 commits June 15, 2023 11:21
… as Norton or Thevenin source

Signed-off-by: Jan Dinkelbach <[email protected]>
Signed-off-by: Jan Dinkelbach <[email protected]>
@dinkelbachjan dinkelbachjan force-pushed the iterative_syngens_config_solver branch from dbab5b6 to 9d485fc Compare June 15, 2023 09:22
@dinkelbachjan dinkelbachjan marked this pull request as ready for review June 15, 2023 09:26
martinmoraga
martinmoraga previously approved these changes Jul 4, 2023
dpsim/include/dpsim/MNASolverDirect.h Show resolved Hide resolved
dpsim-models/src/SP/SP_Ph1_SynchronGenerator4OrderDCIM.cpp Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jul 4, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug E 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 99 Code Smells

0.0% 0.0% Coverage
3.1% 3.1% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@dinkelbachjan dinkelbachjan merged commit b511424 into master Jul 4, 2023
38 of 39 checks passed
@dinkelbachjan dinkelbachjan deleted the iterative_syngens_config_solver branch July 14, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants