Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP2SendSettings? #67

Open
jeffreydking opened this issue May 30, 2019 · 1 comment
Open

HTTP2SendSettings? #67

jeffreydking opened this issue May 30, 2019 · 1 comment

Comments

@jeffreydking
Copy link

Methods exist for

  • HTTP2MatchHeaderFieldPrefixSendSettings()
  • HTTP2MatchHeaderFieldSendSettings()

But there is not a SendSettings option for HTTP2(). Does the existing HTTP2 method not have the same conflict with java gRPC clients as HTTP2MatchHeaderField and HTTP2MatchHeaderFieldPrefix (which require the SendSettings alternatives)?

I would like to match only on the protocol, but need to maintain support for java clients. Is this possible?
@jeffreydking
Copy link
Author

I have found another way to approach my concerns, so this issue is no longer relevant to my needs.

johanbrandhorst added a commit to johanbrandhorst/cmux that referenced this issue Jan 10, 2022
@johanbrandhorst
Use HTTP2MatchHeaderFieldSendSettings in example
2f676e4 
gRPC-Go has been waiting for the settings frame for a while now (soheilhy#64),
and having the old handler in the example is confusing users (soheilhy#67).
Use the new handler in the example and remove the "Limitations" from the README.
johanbrandhorst added a commit to johanbrandhorst/cmux that referenced this issue Jan 10, 2022
@johanbrandhorst
Update README.md
e885ea5 
gRPC-Go has been waiting for the settings frame for a while now (soheilhy#64),
and having the old handler in the example is confusing users (soheilhy#67).
Use the new handler in the example and remove the "Limitations" from the README.
@johanbrandhorst johanbrandhorst mentioned this issue Jan 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jeffreydking