Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot specify {height:xxx} for dropdownStyle. 不能为dropdownStyle指定高度 #6

Closed
cgwu opened this issue Nov 17, 2016 · 3 comments
Labels
Milestone

Comments

@cgwu
Copy link

cgwu commented Nov 17, 2016

道友,懂中文的是吧?不能为dropdownStyle指定高度,指定后报错,dropdownStyle
dropdownStyle={StyleSheet.flatten([styles.dropdownStyle, {height:64}])}
(197行)这一行代码写错了:

let dropdownHeight = (this.props.dropdownStyle && StyleSheet.flatten(this.props.dropdownStyle.height)) || StyleSheet.flatten(styles.dropdown).height; // 应该是: .height) => ).height let dropdownHeight = (this.props.dropdownStyle && StyleSheet.flatten(this.props.dropdownStyle).height) || StyleSheet.flatten(styles.dropdown).height;

@sohobloo
Copy link
Owner

@cgwu
Great job!

So.... 当然懂

@sohobloo sohobloo added this to the v0.3.1 milestone Nov 17, 2016
@sohobloo sohobloo added the bug label Nov 17, 2016
@rumblechen
Copy link

@sohobloo 既然你懂中文,那我就问个问题吧,如何重置一个Dropdown,让它显示defaultValue??求指教

sohobloo pushed a commit that referenced this issue Nov 18, 2016
- Fix bug:
[\#6](#6)
Can not specify `height` style for `dropdownStyle`.
- Remove `updatePosition` function.
@sohobloo
Copy link
Owner

@cgwu

Fixed in v0.3.1

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants