Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Governance: time to vote eneded calculates with cool off time #579

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Governance: time to vote eneded calculates with cool off time #579

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
914bdac
Governance: time to vote eneded calculates with cool off time
ochaloup Mar 1, 2023
6119885
Governance: time to vote eneded review fixes
ochaloup Mar 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/governance-sdk/src/governance/accounts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -946,12 +946,13 @@ export class Proposal {
return this.isPreVotingState()
? governance.config.maxVotingTime
: (this.votingAt?.toNumber() ?? 0) +
governance.config.maxVotingTime -
governance.config.maxVotingTime +
governance.config.votingCoolOffTime -
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

votingCoolOffTime should be applied in both cases.
A better way to do this would be to rename maxVotingTime to baseVotingTime and then have a function for maxVotingTime -> baseVotingTime + votingCoolOffTime

unixTimestampInSeconds;
}

hasVoteTimeEnded(governance: Governance) {
return this.getTimeToVoteEnd(governance) <= 0;
return this.getTimeToVoteEnd(governance) < 0;
}

canCancel(governance: Governance) {
Expand Down