Add support for static syscalls #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that currently this change does not disable old relocation based syscalls. Should we disable them when |
alessandrod
force-pushed
the
static-syscalls
branch
from
af5aa89
to
ea7ec0b
Compare
Lichtso
reviewed
Apr 21, 2022
Lichtso
reviewed
Apr 21, 2022
|
This PR only separates BPF functions and syscalls, but changes nothing about the address space and immediate values, right? |
Correct, this is meant to be 100% backward compatible |
This adds support for static, relocation-less syscalls using the same mechanism as upstream BPF: - CALL_IMMs with src=0 are considered syscalls, where the .imm field is the murmur32 hash of the syscall name - CALL_IMMs with src=1 are considered bpf-to-bpf calls
alessandrod
force-pushed
the
static-syscalls
branch
from
ea7ec0b
to
85e20a7
Compare
18 tasks
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for static, relocation-less syscalls using the same mechanism as upstream BPF:
murmur32 hash of the syscall name
See also solana-labs/solana#24188