Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI workflows for Account Compression PRs #4858

Merged
merged 13 commits into from
Jul 27, 2023

Conversation

ngundotra
Copy link
Contributor

@ngundotra ngundotra commented Jul 25, 2023

CI is needed for account compression after some careless mistakes & miscommunications.

@ngundotra ngundotra changed the title Add ci workflows for account compression PRs Add CI workflows for Account Compression PRs Jul 25, 2023
Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few fly-by comments, this is on the right track!

.github/workflows/pull-request-account-compression.yml Outdated Show resolved Hide resolved
.github/workflows/pull-request-account-compression.yml Outdated Show resolved Hide resolved
@joncinque
Copy link
Contributor

Oh also, if you want this PR to actually run the job, you can also add the CI file to that list

@ngundotra ngundotra force-pushed the ngundotra/ci-account-compression branch 7 times, most recently from e3b5f61 to 61554d0 Compare July 25, 2023 21:53
@ngundotra
Copy link
Contributor Author

@joncinque hm, why didn't the latest commit trigger the job?

@joncinque
Copy link
Contributor

https://github.com/solana-labs/solana-program-library/actions/runs/5662196740 will give the answer -- looks like an issue in the yaml file

@ngundotra ngundotra force-pushed the ngundotra/ci-account-compression branch 2 times, most recently from c77f8bd to 88a1dee Compare July 26, 2023 14:16
@ngundotra ngundotra force-pushed the ngundotra/ci-account-compression branch from a7bac76 to fe30c4e Compare July 26, 2023 16:55
@ngundotra ngundotra marked this pull request as ready for review July 26, 2023 17:37
@ngundotra
Copy link
Contributor Author

@joncinque LFG! CI tests for account compression working 😎

@ngundotra ngundotra requested a review from joncinque July 26, 2023 17:47
Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits to clean up, then this should be good to go!

ci/anchor-cliversion.sh Outdated Show resolved Hide resolved
ci/anchor-cliversion.sh Outdated Show resolved Hide resolved
ci/anchor-cliversion.sh Outdated Show resolved Hide resolved
ci/anchor-cliversion.sh Outdated Show resolved Hide resolved
.github/workflows/pull-request-account-compression.yml Outdated Show resolved Hide resolved
.github/workflows/pull-request-account-compression.yml Outdated Show resolved Hide resolved
ci/program-anchor-build.sh Outdated Show resolved Hide resolved
ci/program-anchor-build.sh Outdated Show resolved Hide resolved
ngundotra and others added 2 commits July 26, 2023 16:25
@ngundotra ngundotra force-pushed the ngundotra/ci-account-compression branch from 63e67d1 to 2f82b92 Compare July 27, 2023 13:23
@ngundotra ngundotra force-pushed the ngundotra/ci-account-compression branch from 45c904d to 09000f6 Compare July 27, 2023 13:52
Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@ngundotra ngundotra merged commit e0a761f into master Jul 27, 2023
8 checks passed
@ngundotra ngundotra deleted the ngundotra/ci-account-compression branch July 27, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants