-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI workflows for Account Compression PRs #4858
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few fly-by comments, this is on the right track!
Oh also, if you want this PR to actually run the job, you can also add the CI file to that list |
e3b5f61
to
61554d0
Compare
@joncinque hm, why didn't the latest commit trigger the job? |
https://github.com/solana-labs/solana-program-library/actions/runs/5662196740 will give the answer -- looks like an issue in the yaml file |
c77f8bd
to
88a1dee
Compare
Co-authored-by: Jon Cinque <[email protected]>
a7bac76
to
fe30c4e
Compare
@joncinque LFG! CI tests for account compression working 😎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few nits to clean up, then this should be good to go!
Co-authored-by: Jon Cinque <[email protected]>
Co-authored-by: Jon Cinque <[email protected]>
Co-authored-by: Jon Cinque <[email protected]>
63e67d1
to
2f82b92
Compare
45c904d
to
09000f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
CI is needed for account compression after some careless mistakes & miscommunications.