Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid transaction data can cause nodes to abruptly terminate #11279

Closed
svenski123 opened this issue Jul 29, 2020 · 0 comments · Fixed by #11282
Closed

Invalid transaction data can cause nodes to abruptly terminate #11279

svenski123 opened this issue Jul 29, 2020 · 0 comments · Fixed by #11282
Labels
security Pull requests that address a security vulnerability

Comments

@svenski123
Copy link
Contributor

svenski123 commented Jul 29, 2020 •
edited
Loading

Problem

Invalid data in submitted transactions can cause nodes to immediately terminate.
Tested in testnet / tds 2020-07-29 22:03 UTC.

In particular, let signature = transaction.signatures[0]; makes assumptions on the number of signatures.

Found in TdS Stage ##6

Proposed Solution

To be discussed
@ryoqun ryoqun added the security Pull requests that address a security vulnerability label Jul 30, 2020
@t-nelson t-nelson mentioned this issue Jul 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
security Pull requests that address a security vulnerability
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reject unsigned transactions sent via RPC t-nelson/solana
2 participants
@ryoqun @svenski123