Reject unsigned transactions sent via RPC #11282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc/ @svenski123 |
garious
approved these changes
Jul 30, 2020
Codecov Report
@@ Coverage Diff @@
## master #11282 +/- ##
=======================================
Coverage 82.4% 82.5%
=======================================
Files 316 316
Lines 74482 74494 +12
=======================================
+ Hits 61442 61473 +31
+ Misses 13040 13021 -19 |
mvines
approved these changes
Jul 30, 2020
t-nelson
added
the
automerge
This was referenced Jul 30, 2020
mergify bot
added a commit
that referenced
this pull request
Jul 30, 2020
* Add failing test for TX sent via RPC with no signatures (cherry picked from commit b962b2c) * Dereplicode send_transaction and request_airdrop RPC handlers (cherry picked from commit a7079e4) * Add new RPC error for TXs with no signatures (cherry picked from commit 9778fed) * Reject TXs sent via RPC with no signatures (cherry picked from commit a888f2f) Co-authored-by: Trent Nelson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Since we use the first signature as a transaction identifier, we can't identify transactions that have not been signed
Summary of Changes
Fixes #11279