Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solana v0.9.0 not on crates.io #1503

Closed
garious opened this issue Oct 15, 2018 · 10 comments
Closed

solana v0.9.0 not on crates.io #1503

garious opened this issue Oct 15, 2018 · 10 comments
Assignees
Milestone

Comments

@garious
Copy link
Contributor

garious commented Oct 15, 2018

We did the work to ensure we weren't referencing any source repos in Cargo.toml. Why didn't the crate get published when we tagged v0.9.0?

@garious garious added this to the The Future! milestone Oct 15, 2018
@garious
Copy link
Contributor Author

garious commented Oct 23, 2018

@mvines, can you ensure the crates.io publishing automation is ready for v0.10.0? Perhaps my making an attempt to publish v0.9.0?

@mvines mvines self-assigned this Oct 24, 2018
@mvines mvines modified the milestones: The Future!, v0.10 Pillbox Oct 24, 2018
@mvines
Copy link
Member

mvines commented Oct 24, 2018

Ok here's where we went off the rails:
https://buildkite.com/solana-labs/solana/builds/4194#44636855-18ec-408b-9b53-1e27578ee05f

+ cargo package
  | Updating registry `https://github.com/rust-lang/crates.io-index`
  | error: all path dependencies must have a version specified when packaging.
  | dependency `solana_program_interface` does not specify a version.

@mvines
Copy link
Member

mvines commented Oct 24, 2018

We might need to fix #1542 first

@mvines
Copy link
Member

mvines commented Oct 25, 2018

cargo workspaces are something of a footgun. Once we started using them for common/ and then in programs/ we ended up in a place where to publish to crates.io we now need to publish the common/ and programs/* creates to crates.io.

Publishing common/ to crates.io seems ok and we want to anyway (#1542), but publishing programs/* crates seems excessive. To avoid this we need to remove all the top-level Cargo program dependencies, ok for all but bpf_loader. bpf_loader needs to either be published, or folded back into src/

@garious
Copy link
Contributor Author

garious commented Oct 25, 2018

Can you move programs to a separate repo?

@garious
Copy link
Contributor Author

garious commented Oct 25, 2018

And bpf_loader back to src/

@garious
Copy link
Contributor Author

garious commented Oct 25, 2018

Nm about moving the other programs. Sounds like that's not required

@mvines
Copy link
Member

mvines commented Oct 25, 2018

#1612

@mvines
Copy link
Member

mvines commented Oct 25, 2018

Next step is to wait until v0.10 branches off master tonight, try to publish a 0.10.0-pre.1 release and see what happens. On success we'll see five crates on crates.io all with the same semver:

solana
solana-sdk
solana-noop
solana-bpfloader
solana-lualoader

@mvines
Copy link
Member

mvines commented Oct 26, 2018

New publishing infra works: https://crates.io/search?q=solana

@mvines mvines closed this as completed Oct 26, 2018
vkomenda pushed a commit to vkomenda/solana that referenced this issue Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants