Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abort if the open fd limit cannot be increased #10064

Merged
merged 1 commit into from
May 15, 2020
Merged

Abort if the open fd limit cannot be increased #10064

merged 1 commit into from
May 15, 2020

Conversation

mvines
Copy link
Member

@mvines mvines commented May 15, 2020

While we emit an error log when the fd limit can't be increased, the validator/ledger-tool still trucks on and will likely generate an unexpected failure sometime later in execution. Better to fail fast and make the user deal with the issue up front.

@mvines mvines requested a review from t-nelson May 15, 2020 16:38
t-nelson
t-nelson previously approved these changes May 15, 2020
View reviewed changes
Copy link
Contributor

@t-nelson t-nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mergify mergify bot dismissed t-nelson’s stale review May 15, 2020 17:30

Pull request has been modified.

@mvines mvines added the automerge Merge this Pull Request automatically once CI passes label May 15, 2020
@solana-grimes solana-grimes merged commit 7080fb9 into solana-labs:master May 15, 2020
mergify bot pushed a commit that referenced this pull request May 15, 2020
@mvines
Abort if the open fd limit cannot be increased (#10064)
e8d3eda 
automerge

(cherry picked from commit 7080fb9)

# Conflicts:
#	ledger/src/blockstore_db.rs
@mergify mergify bot mentioned this pull request May 15, 2020
Merged
mergify bot pushed a commit that referenced this pull request May 15, 2020
@mvines
Abort if the open fd limit cannot be increased (#10064)
3349251 
automerge

(cherry picked from commit 7080fb9)

# Conflicts:
#	ledger/src/blockstore_db.rs
@mergify mergify bot mentioned this pull request May 15, 2020
Merged
@mvines mvines deleted the fd branch May 15, 2020 20:11
solana-grimes pushed a commit that referenced this pull request May 15, 2020
@mergify
Abort if the open fd limit cannot be increased (bp #10064) (#10074)
7bc915c 
automerge
solana-grimes pushed a commit that referenced this pull request May 15, 2020
@mergify
Abort if the open fd limit cannot be increased (bp #10064) (#10073)
198f87f 
automerge
@Kashuhackerone Kashuhackerone mentioned this pull request May 4, 2024
Open
@masakazu12 masakazu12 mentioned this pull request May 4, 2024
Open
@q1blue q1blue mentioned this pull request May 4, 2024
Open
@adamlaska adamlaska mentioned this pull request Oct 8, 2024
Open
@CASABECI CASABECI mentioned this pull request Oct 9, 2024
Open
@BuloZB BuloZB mentioned this pull request Oct 10, 2024
Open
This was referenced Oct 11, 2024
Open
Open
@Digiminey Digiminey mentioned this pull request Oct 14, 2024
Open
@kalbroni7 kalbroni7 mentioned this pull request Oct 14, 2024
Open
@masakazu12 masakazu12 mentioned this pull request Oct 15, 2024
Open
@adamlaska adamlaska mentioned this pull request Oct 15, 2024
Open
@CASABECI CASABECI mentioned this pull request Oct 16, 2024
Open
@adamlaska adamlaska mentioned this pull request Oct 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-nelson t-nelson t-nelson left review comments

Assignees
No one assigned
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvines @t-nelson @solana-grimes